Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin protobuf to 3.20.* #1412

Merged
merged 1 commit into from
May 26, 2022
Merged

Pin protobuf to 3.20.* #1412

merged 1 commit into from
May 26, 2022

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented May 26, 2022

Overview

This fixes the error described in: protocolbuffers/protobuf#10051

CI builds were breaking during the unit testing step with that error.

Checklist

  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

scripts/unit_tests should work.

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #1412 (a071f7d) into master (4619494) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
- Coverage   71.36%   71.35%   -0.02%     
==========================================
  Files         173      173              
  Lines        8315     8315              
==========================================
- Hits         5934     5933       -1     
- Misses       2381     2382       +1     
Impacted Files Coverage Δ
...ervision/pytorch_learner/classification_learner.py 73.56% <0.00%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4619494...a071f7d. Read the comment docs.

@AdeelH AdeelH merged commit ee3a694 into azavea:master May 26, 2022
@AdeelH AdeelH deleted the protobuf branch September 28, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant