Fix(black temple) gathios the shatterer shouldnt use hammer of justice on random players #19653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kitzunu
reviewed
Aug 18, 2024
Kitzunu
reviewed
Aug 18, 2024
Kitzunu
reviewed
Aug 18, 2024
|
I don't know why it shows my other github account in the last commit |
Kitzunu
reviewed
Aug 18, 2024
Probably the account that you have set up for git |
|
ok, now I have switched to the correct git account |
heyitsbench
reviewed
Aug 18, 2024
| @@ -709,5 +696,4 @@ void AddSC_boss_illidari_council() | |||
| RegisterSpellScript(spell_illidari_council_reflective_shield_aura); | |||
| RegisterSpellScript(spell_illidari_council_judgement); | |||
| RegisterSpellScript(spell_illidari_council_deadly_strike_aura); | |||
| } | |||
|
|
|||
| } | |||
heyitsbench
reviewed
Aug 18, 2024
Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Nyeriah
approved these changes
Aug 18, 2024
natrist
pushed a commit
to openwow-org/azerothcore-wotlk
that referenced
this pull request
Aug 20, 2024
…f Justice on random players (azerothcore#19653) * fix: SelectTargetMethod Random replaced with MaxThreat * restore like origin * fix: cast Hammer Of Justice on current target instead random target * refactor: case EVENT_SPELL_HAMMER_OF_JUSTICE statement refactored * refactor: if statement splitted * refactor: last space removed * Update src/server/scripts/Outland/BlackTemple/illidari_council.cpp Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com> * fix redundant check and new line --------- Co-authored-by: MattiaBallarini <ballarini.mattia1990@gmail.com> Co-authored-by: Andrew <47818697+Nyeriah@users.noreply.github.com> Co-authored-by: Benjamin Jackson <38561765+heyitsbench@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
- Closes
- Closes
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.