Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Creature): Quest Escape through Force - party completion issue #19733

Conversation

Carriola-wotlk
Copy link
Contributor

@Carriola-wotlk Carriola-wotlk commented Aug 25, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Aug 25, 2024
@Carriola-wotlk Carriola-wotlk changed the title party completion fixed fix(DB/Creature): Quest Escape through Force - party completion issue Aug 25, 2024
@Nyeriah
Copy link
Member

Nyeriah commented Aug 25, 2024

Instead of storing target list please try SMART_ACTION_CALL_GROUPEVENTHAPPENS or SMART_TARGET_INVOKER_PARTY

@Carriola-wotlk
Copy link
Contributor Author

Carriola-wotlk commented Aug 27, 2024

Instead of storing target list please try SMART_ACTION_CALL_GROUPEVENTHAPPENS or SMART_TARGET_INVOKER_PARTY

storing target list rows already existed in this smart_script and the saved variable is used in other parts of the smart script. Those queries are actually updates, not inserts. I only modified the invoker type

@Nyeriah Nyeriah merged commit 3463bdd into azerothcore:master Aug 28, 2024
13 checks passed
natrist pushed a commit to openwow-org/azerothcore-wotlk that referenced this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Quest] Escape through Force - party completion issue.
2 participants