Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(db/creature) black temple illidari assassin riposte ability missing #19957

Conversation

Carriola-wotlk
Copy link
Contributor

@Carriola-wotlk Carriola-wotlk commented Sep 13, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

Actually, the bug is a bit different from how it was described in this ticket. The first spawned Assassin only casts Paralyzing Poison and Vanish abilities (and doesn't cast Riposte). The other 3 spawns don't cast anything, they only perform melee attacks.

So in the bugfix, I didn't modify the existing spells, but I added new row for Riposte. As for the timers, I checked the logs here: link. It seems that the first Riposte is cast within 15 seconds. And then I modified flags_extra by setting DONT_OVERRIDE_SAI_ENTRY (so that all 4 NPCs use the SAI).

Cattura
Cattura2
Cattura3
Cattura4

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the DB related to the SQL database label Sep 13, 2024
@@ -0,0 +1,5 @@
UPDATE `creature_template` SET `flags_extra` = 134217728 WHERE (`entry` = 23403);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the bitwise method to update bitmasks e.g

To add:
flags_extra = flags_extra | $flag

To remove:
flags_extra = flags_extra &~ $flag

@Rorschach91
Copy link

I tested the script and It works. It can be merged for me.

@Helias Helias merged commit 1d899cf into azerothcore:master Sep 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database To Be Merged
Projects
None yet
4 participants