Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/main' into test_repo_breaking_ch…
Browse files Browse the repository at this point in the history
…ange_mlc
  • Loading branch information
wanlwanl committed Aug 21, 2024
2 parents a020048 + 5586f99 commit 2973f58
Show file tree
Hide file tree
Showing 518 changed files with 46,747 additions and 6,799 deletions.
10 changes: 8 additions & 2 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@

/** @xirzec @jeremymeng @Azure/azure-sdk-eng

################
# CODEOWNERS
################

/.github/CODEOWNERS @xirzec @jeremymeng @qiaozha @MaryGao @Azure/azure-sdk-eng

################
# Misc.
################
Expand Down Expand Up @@ -114,7 +120,7 @@
# AzureSdkOwners: @timovv @jeremymeng

# ServiceLabel: %Cosmos %Service Attention
# ServiceOwners: @sajeetharan @simorenoh
# ServiceOwners: @sajeetharan @simorenoh

# PRLabel: %Cosmos
/sdk/cosmosdb/ @amanrao23 @aditishree1 @sajeetharan @topshot99
Expand Down Expand Up @@ -214,7 +220,7 @@

# PRLabel: %WebPubSub
# ServiceLabel: %WebPubSub
/sdk/web-pubsub/ @vicancy
/sdk/web-pubsub/ @vicancy @chenkennt @zackliu

# PRLabel: %EngSys
/sdk/template/ @ckairen @mikeharder @weshaggard @benbp
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/event.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
pull-requests: write # to read pull requests and write comments (azure/azure-sdk-actions)
checks: read # to read check status (azure/azure-sdk-actions)
name: Handle ${{ github.event_name }} ${{ github.event.action }} event
runs-on: ubuntu-latest
runs-on: ubuntu-latest # This image is intentionally set to "latest", and not to a specific version
steps:
- uses: azure/azure-sdk-actions@main
with:
Expand Down
8 changes: 7 additions & 1 deletion .vscode/cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,13 @@
"usgovtexas",
"usgovvirginia",
"vectorizer",
"westus"
"westus",
"reimaging",
"upgradingos",
"Cifs",
"dataserviceid",
"uefi",
"Uefi"
],
"allowCompoundWords": true,
"overrides": [
Expand Down
10 changes: 9 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,15 @@ Our libraries follow the [TypeScript SDK design guidelines](https://azure.github

You can run the plugin by excuting `rushx lint` inside your package directory.

If the package is internal, it should not follow the design guidelines and in turn should not be linted by the plugin. In this case, use the [internal configuration file](https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/.eslintrc.internal.json) instead. For example: `"lint": "eslint --no-eslintrc -c ../../.eslintrc.internal.json package.json package.json src test --ext .ts"`
If the package is internal, it should not follow the design guidelines and in turn should not be linted by the plugin. In this case, use the an internal config from `eslint-plugin-azure-sdk` instead. For example: `"lint": "eslint src test"` with the following eslint.config.mjs

```javascript
import azsdkEslint from "@azure/eslint-plugin-azure-sdk";

export default [
...azsdkEslint.configs.internal,
];
```

## Onboarding a new library

Expand Down
Loading

0 comments on commit 2973f58

Please sign in to comment.