Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-apimanagement] feat(apim): Introduce gateway resource #8420

Closed
wants to merge 64 commits into from

Conversation

azure-sdk
Copy link
Owner

Create to sync Azure/azure-rest-api-specs#27757

Please install the package by npm install https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/27757/azure-sdk-for-js/@azure_arm-apimanagement/azure-arm-apimanagement-10.0.0-beta.1.tgz

@github-actions github-actions bot added the Mgmt label Feb 13, 2024
@azure-sdk azure-sdk force-pushed the sdkAuto/27757/@azure_arm-apimanagement branch 15 times, most recently from e1f97b7 to 15050b8 Compare February 17, 2024 19:02
hectorhdzg and others added 13 commits March 8, 2024 10:02
…ents (Azure#28823)

### Packages impacted by this PR
@azure/monitor-opentelemetry
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7842 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Anne Thompson <annelo@microsoft.com>
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7835 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
…ure#28842)

Sync .github/workflows directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7845 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: James Suplizio <jasupliz@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
### Packages impacted by this PR

@azure/identity

### Issues associated with this PR

Nightly test failures

### Describe the problem that is addressed by this PR

Our nightly tests started failing with a `TypeError: Descriptor for
property generatePluginConfiguration is non-configurable and non-writable` error.

I'm far from an expert here, but I believe the error is due to ESModules
being immutable, whereas CJS Modules are mutable.

Wrapping the stubbable / mockable object is a reasonable workaround to
keep tests green regardless of whether they get run as ESM or CJS

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

Deleting the tests is an option, or an integration test. Neither seem to
fit the bill here. Once we have credentials migrated over we may be able to
delete some of the unit tests and rely on recorded tests to test the various
scenarios. But we are not there yet.
… Package (Azure#28827)

### Packages impacted by this PR
@azure/monitor-opentelemetry

### Describe the problem that is addressed by this PR
Package should be updated to the latest version and tests updated
appropriately.

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
### Packages impacted by this PR

@azure/core-client

### Issues associated with this PR

N/A, follow up on Azure#28631 

### Describe the problem that is addressed by this PR

If you are exporting both CommonJS and ESM forms of a package, then it
is possible for both versions to be loaded at
run-time. However, the CommonJS build is a different module from the ESM
build, and thus a different thing from the
point of view of the JavaScript interpreter in Node.js.

https://github.com/isaacs/tshy/blob/main/README.md#dual-package-hazards

tshy handles this by building programs into separate folders and treats
"dual module hazards" as a fact of life.

One of the hazards of dual-modules is shared module-global state.

In core-clientwe have a module-global operationRequestMap that is used
for deserializing. In order to ensure it works in this dual-package world we 
must use one of multiple-recommended workarounds.

In this case, the tshy documentation provides a solution to this with a
well-documented path forward. This is what is implemented here.

Please refer to
https://github.com/isaacs/tshy/blob/main/README.md#module-local-state
for added context

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?

The obvious alternative is to just not do anything since tests have not
been failing; however, that
seems risky. While _this_ particular issue has not come up in tests, a
similar one came up for core-tracing.

I am open to just _not_ doing anything of course - I love not adding
code so just give me a reason!
…8840)

### Packages impacted by this PR
@azure/monitor-opentelemetry-exporter
### Packages impacted by this PR

- @azure/dev-tool

### Issues associated with this PR


### Describe the problem that is addressed by this PR

Reverts back to the original for the testing ts-node for JS and TS.

### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_

- Azure#28801

### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
Update emitter packages.
…ure#28864)

Sync .github/workflows directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7848 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: James Suplizio <jasupliz@microsoft.com>
### Packages impacted by this PR

- @azure/keyvault-keys
- @azure/keyvault-admin
- @azure/keyvault-secrets

### Describe the problem that is addressed by this PR

Fixes the glob path issue with the upgrade to `rimraf` since there were
extra calls to `rimraf` after the standard calls.
The `azsdkjsrush` storage account has seemingly been deleted, so this
will always fail and waste effort during CI.

Tracking issue for a full fix: Azure#28865
EmmaZhu and others added 6 commits March 15, 2024 13:55
…28913)

### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)


### Packages impacted by this PR


### Issues associated with this PR


### Describe the problem that is addressed by this PR


### What are the possible designs available to address the problem? If
there are more than one possible design, why was the one in this PR
chosen?


### Are there test cases added in this PR? _(If not, why?)_


### Provide a list of related PRs _(if any)_


### Command used to generate this PR:**_(Applicable only to SDK release
request PRs)_

### Checklists
- [ ] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [ ] Added a changelog (if necessary)
### Packages impacted by this PR
@azure/monitor-opentelemetry

### Checklists
- [x] Added impacted package name to the issue description
- [ ] Does this PR needs any fixes in the SDK Generator?** _(If so,
create an Issue in the
[Autorest/typescript](https://github.com/Azure/autorest.typescript)
repository and link it here)_
- [x] Added a changelog (if necessary)
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#7892 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

---------

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
@azure-sdk azure-sdk force-pushed the sdkAuto/27757/@azure_arm-apimanagement branch from a60a82e to 420225b Compare March 19, 2024 06:49
@azure-sdk azure-sdk closed this Mar 24, 2024
@azure-sdk azure-sdk deleted the sdkAuto/27757/@azure_arm-apimanagement branch March 24, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.