Add two new flags to enable HTTP Server and clients logs #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-candidate #166 +/- ##
==================================================
Coverage 99.61% 99.61%
==================================================
Files 166 166
Lines 13457 13539 +82
==================================================
+ Hits 13405 13487 +82
Misses 52 52 ☔ View full report in Codecov by Sentry. |
jvanecek
force-pushed
the
zinc-logging
branch
from
9e7afc6
to
e920cd5
Compare
jvanecek
changed the title
mtabacman
previously approved these changes
Dec 19, 2022
gcotelli
requested changes
Jul 2, 2024
jvanecek
changed the title
jvanecek
changed the title
mtabacman
previously approved these changes
Jul 3, 2024
… incoming requests logging parameterization this is because the StargateApplication is an HTTP Server and doesn't make sense to include the outgoing logging parameterization since it will not be necessary used.
gcotelli
requested changes
Jul 4, 2024
source/Stargate-API-Skeleton-Tests/StargateApplicationTest.class.st
Outdated
Show resolved
Hide resolved
gcotelli
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.