Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For the /node config, disable all eslint-plugin-n rules related to import and require that have too many false positives #7

Merged
merged 1 commit into from
Dec 7, 2023
Merged

For the /node config, disable all eslint-plugin-n rules related to import and require that have too many false positives #7

merged 1 commit into from
Dec 7, 2023

Conversation

mangs
Copy link
Contributor

@mangs mangs commented Dec 7, 2023

Pull Request Checklist

Changes Included

  • Version bump to 1.0.1
  • For the /node config, disable all eslint-plugin-n rules related to import and require that have too many false positives:
    • n/no-extraneous-import
    • n/no-extraneous-require
    • n/no-missing-import
    • n/no-missing-require
    • n/no-unpublished-import
    • n/no-unpublished-require

@mangs
For the /node config, disable all eslint-plugin-n rules related t…
f9481c6 
…o `import` and `require` that have too many false positives
@mangs mangs requested a review from jduthon as a code owner December 7, 2023 18:28
Jhojan28
Jhojan28 approved these changes Dec 7, 2023
View reviewed changes
Copy link

@Jhojan28 Jhojan28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mangs mangs merged commit 36ea54f into babbel:main Dec 7, 2023
1 check passed
@mangs mangs deleted the reduce-node-false-positives branch December 7, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jhojan28 Jhojan28 Jhojan28 approved these changes

@jduthon jduthon Awaiting requested review from jduthon

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mangs @Jhojan28