Skip to content
This repository has been archived by the owner on May 19, 2018. It is now read-only.

Distinguish between ternary's : and arrow fn's return type #596

Merged
merged 4 commits into from
Sep 25, 2017
Merged

Distinguish between ternary's : and arrow fn's return type #596

merged 4 commits into from
Sep 25, 2017

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jun 28, 2017

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets #58, #429
License MIT

@hzoo This is #573 but without flow errors. Apart from 5f176cb, this code has already been reviewed.

@nicolo-ribaudo nicolo-ribaudo changed the title Issue 58 ternary arrow flow Distinguish between ternary's : and arrow fn's return type Jun 28, 2017
@nicolo-ribaudo
Copy link
Member Author

I rebased to resolve the merge conflicts. I squashed the commits because, since I wrote an implementation of the logic to avoid throwing errors for parenthesized expressions which are not valid parameters and then totally rewrote it, I would have needed to resolve the conflicts for a lot of unuseful commits.

The original commits can be found at https://github.com/nicolo-ribaudo/babylon/tree/issue-58-ternary-arrow-flow-copy

@nicolo-ribaudo
Copy link
Member Author

I just pushed some minor changes (fixed three new flow errors and removed some duplicated code)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants