Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Librespot Credentials Optional #181

Merged

Conversation

airdrummingfool
Copy link
Contributor

librespot does not require credentials in order to work.

from the README:

librespot can be run in discovery mode, in which case no password is required at startup. For that, simply omit the --username argument.

This PR allows both username and password to be omitted. If one is provided and the other is not, an error is thrown.

…nly throwing an error if one is provided without the the other.
@badaix
Copy link
Owner

badaix commented Feb 8, 2017

What is the discovery mode? Can it play audio in this mode? What is the difference to the "Spotify connect" mode (my understanding is that in the "Spotify connect" mode, it can be used as a remote player instance).
I currently don't have a payed account, so I cannot test it.

@airdrummingfool
Copy link
Contributor Author

I've always used discovery mode in my setup, because I don't like entering my username and password. From what I can tell, "Discovery Mode" starts librespot in a state that is waiting for an auth token, which it gets from another client when you select the librespot instance in a client's Spotify Connect list.

Discovery Mode can play audio. I don't think it's actually different than "Spotify Connect" mode, except that it has to wait to get auth info from another Spotify client (which happens automatically when you tell librespot to play music from another client). It still functions as a remote player.

@badaix
Copy link
Owner

badaix commented Feb 8, 2017

aha, cool 👍

@badaix badaix merged commit d8ed73c into badaix:develop Feb 8, 2017
@airdrummingfool airdrummingfool deleted the librespot-optional-credentials branch March 12, 2017 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants