fix: computed 应该在 inited 之前调用

baidu · Dec 3, 2021 · aa21455 · aa21455
1 parent ae6c698
commit aa21455
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 5 deletions.
diff --git a/src/compilers/renderer-compiler.ts b/src/compilers/renderer-compiler.ts
@@ -69,6 +69,11 @@ export class RendererCompiler {
             body.push(...this.emitInitData())
         }
 
+        // calc computed
+        for (const name of info.getComputedNames()) {
+            body.push(ASSIGN(BINARY(I('data'), '[]', L(name)), new ComputedCall(name)))
+        }
+
         // call inited
         if (info.hasMethod('inited')) {
             body.push(createTryStatement(
@@ -82,11 +87,6 @@ export class RendererCompiler {
             ))
         }
 
-        // calc computed
-        for (const name of info.getComputedNames()) {
-            body.push(ASSIGN(BINARY(I('data'), '[]', L(name)), new ComputedCall(name)))
-        }
-
         body.push(DEF('html', L('')))
         body.push(ASSIGN(I('parentCtx'), I('ctx')))
         const aNodeCompiler = new ANodeCompiler(info, !!this.options.ssrOnly, this.id, this.options.useProvidedComponentClass)

diff --git a/test/unit/runtime/underscore.spec.ts b/test/unit/runtime/underscore.spec.ts
@@ -58,6 +58,16 @@ describe('utils/underscore', function () {
             expect(_.createInstanceFromClass(MyComponent)).toHaveProperty('inited')
             expect(inited).not.toHaveBeenCalled()
         })
+        it('should not call initData', () => {
+            const mockFn = jest.fn()
+            class MyComponent extends Component {
+                initData () {
+                    mockFn()
+                }
+            }
+            expect(_.createInstanceFromClass(MyComponent)).toHaveProperty('initData')
+            expect(mockFn).not.toHaveBeenCalled()
+        })
         it('should not call computed', () => {
             const foo = jest.fn()
             class MyComponent extends Component {