Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

调用 ts2php 时丢失项目根路径信息， 且虚拟 CommonJS 支持可配置模块时没有覆盖到常规的 node_module #19

Closed
l5oo00 opened this issue Nov 9, 2019 · 2 comments
Closed

调用 ts2php 时丢失项目根路径信息， 且虚拟 CommonJS 支持可配置模块时没有覆盖到常规的 node_module #19

l5oo00 opened this issue Nov 9, 2019 · 2 comments
Labels
released

Comments

@l5oo00
Copy link
Contributor

l5oo00 commented Nov 9, 2019

  • 基于 虚拟 CommonJS 需要支持可配置模块 开发时， 发现 modules 的 key 为一个 node module 模块名时会被忽略。

  • 调用 ts2php 时丢失项目根路径信息， 导致 ts2php 无法查找到项目内定义的类型信息， 可能会导致转换错误或失败。
@harttle harttle closed this as completed in 279769a Nov 9, 2019
harttle added a commit that referenced this issue Nov 9, 2019
@harttle
Merge pull request #20 from l5oo00/master
e89b148 
fix: format compilerOptions for ts2php, fixes #19
harttle pushed a commit that referenced this issue Nov 9, 2019
@semantic-release-bot
chore(release): 1.3.2 [skip ci]
9b607dc 
## [1.3.2](v1.3.1...v1.3.2) (2019-11-09)

### Bug Fixes

* format compilerOptions for ts2php, fixes [#19](#19) ([279769a](279769a))
@harttle
Copy link
Member

harttle commented Nov 9, 2019

🎉 This issue has been resolved in version 1.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

harttle pushed a commit that referenced this issue Nov 14, 2019
@l5oo00 @harttle
fix: format compilerOptions for ts2php, fixes #19
cb2329d
harttle pushed a commit that referenced this issue Nov 14, 2019
@semantic-release-bot @harttle
chore(release): 1.3.2 [skip ci]
ce37d16 
## [1.3.2](v1.3.1...v1.3.2) (2019-11-09)

### Bug Fixes

* format compilerOptions for ts2php, fixes [#19](#19) ([279769a](279769a))
harttle pushed a commit that referenced this issue Nov 14, 2019
@semantic-release-bot
chore(release): 1.3.4 [skip ci]
4876d56 
## [1.3.4](v1.3.3...v1.3.4) (2019-11-14)

### Bug Fixes

* format compilerOptions for ts2php, fixes [#19](#19) ([cb2329d](cb2329d))
* remove <!--s-text--><!--/s-text--> when noDataOutput is true, fixes [#21](#21) ([c05ef7d](c05ef7d))
@harttle
Copy link
Member

harttle commented Nov 14, 2019

🎉 This issue has been resolved in version 1.3.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@l5oo00 @harttle