Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Test Character testing #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

louispires
Copy link

Separated out changes as requested by @chrisys #51

if FONT_SIZE <= 17:
FONT_SIZE = 8
if FONT_SIZE <= 12:
FONT_SIZE = 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been testing and I think here you might be making changes specific to the Waveshare display, the pixel font in size 10 on the InkyPHAT isn't readable at all, and the same goes for allowing the selected font to go down to 12, probably because the display is a slightly different resolution. I'd be happy to merge the optimisations but we'll need to make them specific to that display when it comes to sizes. We could also consider default values specific to the display type, but user-configurable too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants