Refine migrator internals #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch Signed-off-by: Ken Bannister <kb2ma@runbox.com>
* Add abstractions for target device and partition * Only look for volume info if partition pre-existing Change-type: patch Signed-off-by: Ken Bannister <kb2ma@runbox.com>
|
I self-certify! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of improvements for the migrator functionality:
Refine
findVolume()to work independent of localization differences. This function is based on the Windows diskpart tool, so column headings change with localization. Updated to purely use the structure of the table to find relevant columns and data.Refactor the migrator function itself to add abstractions for the target storage device and target partitions. These abstractions provide a single container for Etcher based data and Windows (or other OS) based data.