Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos notarization: Expose team ID instead of keeping it in secrets #2640

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

myarmolinsky
Copy link
Member

macos notarization: Expose team ID instead of keeping it in secrets

Change-type: patch


Please check the CONTRIBUTING.md file for relevant information and some
guidance. Keep in mind that the CLI is a cross-platform application that runs
on Windows, macOS and Linux. Tests will be automatically run by balena CI on
all three operating systems, but this will only help if you have added test
code that exercises the modified or added feature code.

Note that each commit message (currently only the first line) will be
automatically copied to the CHANGELOG.md file, so try writing it in a way
that describes the feature or fix for CLI users.

If there isn't a linked issue or if the linked issue doesn't quite match the
PR, please add a PR description to explain its purpose or the features that it
implements. Adding PR comments to blocks of code that aren't self explanatory
usually helps with the review process.

If the PR introduces security considerations or affects the development, build
or release process, please be sure to highlight this in the PR description.

Thank you very much for your contribution!

@myarmolinsky myarmolinsky requested a review from ab77 June 29, 2023 11:43
@myarmolinsky myarmolinsky self-assigned this Jun 29, 2023
@flowzone-app flowzone-app bot enabled auto-merge June 29, 2023 11:44
@myarmolinsky
Copy link
Member Author

LGTM

@flowzone-app flowzone-app bot merged commit e0a3c4b into master Jun 29, 2023
48 checks passed
@flowzone-app flowzone-app bot deleted the make-apple-notarization-team-id-public branch June 29, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant