This repository has been archived by the owner on Mar 30, 2021. It is now read-only.
Ci build #69
Merged
Ci build #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigmulligan
force-pushed
the
ci-build
branch
3 times, most recently
from
ff7b17e
to
67de42d
Compare
lurch
reviewed
Jun 22, 2017
config/locals.json
Outdated
| @@ -3,7 +3,7 @@ | |||
| "title": "Etcher", | |||
| "prefix": "", | |||
| "slogan": "Burn. Better.", | |||
| "lead": "Burn images to SD cards & USB drives, safe & easy.", | |||
| "lead": "Burn images to SD cards & USB drives, safely and easily.", | |||
There was a problem hiding this comment.
Ahh, sorry I forgot to commit the changes to this file too, but that's because I was using the GH web-editor rather than building locally :-/
To prevent similar slip-ups in future, I guess you could run git status -s after running yarn run export and checking that git-status returns an empty string (i.e. none of the files in the repo got modified). See e.g. https://github.com/resin-io/etcher/blob/master/scripts/ci/ensure-staged-shrinkwrap.sh
There was a problem hiding this comment.
Yea, we actually don't need that file in the git history. It's just used as cache at build time, I'll rm it.
|
CI tests are now broken :-/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connects to #41
This builds the site, and runs progress web metrics tests, which will warn us if we are exceeding our base-line limits for time to first paint, time to interactive etc.
Next we should add auto deploy.