fix: range rendered in jump-on-scroll and stick-to-end #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulienIzz
force-pushed
the
fix/range-rendered
branch
from
62d5516
to
28f73d4
Compare
remilry
reviewed
Aug 29, 2024
.../src/spatial-navigation/components/virtualizedList/SpatialNavigationVirtualizedList.test.tsx
Show resolved
Hide resolved
remilry
reviewed
Aug 29, 2024
packages/lib/src/spatial-navigation/components/virtualizedList/helpers/getRange.ts
Show resolved
Hide resolved
JulienIzz
commented
Sep 4, 2024
packages/lib/src/spatial-navigation/components/virtualizedList/helpers/getRange.ts
Outdated
Show resolved
Hide resolved
pierpo
reviewed
Sep 9, 2024
packages/lib/src/spatial-navigation/components/virtualizedList/helpers/getRange.test.ts
Outdated
Show resolved
Hide resolved
pierpo
reviewed
Sep 9, 2024
packages/lib/src/spatial-navigation/components/virtualizedList/helpers/getRange.ts
Outdated
Show resolved
Hide resolved
pierpo
reviewed
Sep 9, 2024
packages/lib/src/spatial-navigation/components/virtualizedList/helpers/getRange.ts
Show resolved
Hide resolved
pierpo
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before - stick-to-end
before_end.mov
After - stick-to-end
after_end.mov
Before - jump-on-scroll
before_jump.mov
After - jump-on-scroll
after_jump.mov
Bug description