Fix return value of query scopes from parent class #1366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sforward
force-pushed
the
fix/query-scope-parent-class
branch
from
6e5dd0c
to
4f72d0e
Compare
mfn
approved these changes
Apr 1, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the return value of query scope methods that are defined in a parent class of the target model. At the moment the return value contains the class name where the method is located:
@method static \Illuminate\Database\Eloquent\Builder|PostParent active(), and with this change it correctly becomes@method static \Illuminate\Database\Eloquent\Builder|Post active(). See included test for more context.Type of change
Checklist
composer fix-style