-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cannot import name 'AggsProxy' from elasticsearch_dsl.search #314
Comments
change |
Yes but this import is in the |
Folks, I'm very like to use this package again for a project soon. I'll make sure to solve all the issues then. |
@barseghyanartur The issue here is that your The easy solution would be for you to import this If we were to implement our own version of |
Thanks for the suggestion. Please, show me what you have. Alternatively, if that's something that needs to be easily swappable, I can think of ways to make it swappable. |
@barseghyanartur when you have a moment have a look at the
This is not in a released version yet so you'll need to install the main branch of elasticsearch-dsl-py to get it. This should be a more robust version of yours that is less likely to break in the future. |
@barseghyanartur we have just released 8.13.1, including our version of |
Thanks. Question. Regarding the compatibility, is elasticsearch-dsl-py 7.x branch still supported? Or is it no longer? Simply switching to 8.x would mean compatibility issues. I could however, make this EmptySearch quite compatible with whatever you have in your branch. Or really make it swappable. Perhaps, that's the best option. |
@barseghyanartur The 7.x branch is still supported. What I suggest that you do is to try to import try:
from elasticsearch_dsl import EmptySearch
except ImportError:
class EmptySearch:
# your own version of this class I think this would allow you to support all the 7.x and 8.x versions. Would this work for you? |
@barseghyanartur just checking to see where we are with this ticket. We rather not pin the Thanks. |
@barseghyanartur , if @priyanshu69code 's change looks good to you , can we apply that change here as well ? Thanks. |
Hi, @selimt, @barseghyanartur and @priyanshu69code There is one more place where this import needs to be updated: Below is the link --> |
Ok sure But I think I have updated the imports at both the place. But let me confirm that. |
When running on Python 3.9 with the latest
elasticsearch_dsl
release (8.13.0), we are getting the following traceback:Pinning
elasticsearch_dsl
to8.12.0
gets around the problem.Thanks
-Selim
The text was updated successfully, but these errors were encountered: