Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basenames frames tutorial #1005

Merged
merged 12 commits into from
Sep 20, 2024
Merged

Conversation

hughescoin
Copy link
Collaborator

What changed? Why?
A tutorial on how to add a Frame to a Basename profile

Notes to reviewers

How has it been tested?

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 5:12pm

Copy link

vercel bot commented Sep 19, 2024

@hughescoin is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 19, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for JFrankfurt @ 2024-09-20 16:55:59 UTC
User failed mfa authentication, see go/mfa-help

@hughescoin hughescoin merged commit b0ab81d into base-org:master Sep 20, 2024
4 of 5 checks passed
@hughescoin hughescoin deleted the basenames-frames branch September 22, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants