Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECO-219: Fix mobile / desktop success UI #736

Merged
merged 1 commit into from
Jul 30, 2024
Merged

ECO-219: Fix mobile / desktop success UI #736

merged 1 commit into from
Jul 30, 2024

Conversation

kirkas
Copy link
Collaborator

@kirkas kirkas commented Jul 30, 2024

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jul 30, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel Vercel
Copy link

vercel bot commented Jul 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 5:35pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 5:35pm

@kirkas kirkas merged commit 6f3b5c1 into master Jul 30, 2024
8 checks passed
@kirkas kirkas deleted the ECO-220-mobile-success-page branch July 30, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zencephalon zencephalon zencephalon approved these changes

@JFrankfurt JFrankfurt Awaiting requested review from JFrankfurt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirkas @cb-heimdall @zencephalon