Chore/datadog instrumentation #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Heimdall Review Status
|
omkarb
requested review from
kirkas,
brendan-defi and
JFrankfurt
and removed request for
kirkas and
brendan-defi
JFrankfurt
reviewed
Jul 30, 2024
apps/base-docs/server.js
Outdated
Comment on lines
434
to
435
| 'https://app.datadoghq.com', // datadog | ||
| 'datadoghq.com' // datadog |
There was a problem hiding this comment.
Suggested change
| 'https://app.datadoghq.com', // datadog | |
| 'datadoghq.com' // datadog | |
| 'https://*.datadoghq.com', // datadog |
I think you can wildcard this to get https enforcement and auth all subdomains
JFrankfurt
reviewed
Jul 30, 2024
apps/web/.env.local.example
Outdated
Comment on lines
20
to
21
| DD_CLIENT_ID= |
There was a problem hiding this comment.
nit: would be nice to have DATADOG for clarity
JFrankfurt
reviewed
Jul 30, 2024
apps/web/next.config.js
Outdated
Comment on lines
102
to
103
| 'https://app.datadoghq.com', // datadog | ||
| 'datadoghq.com' // datadog |
There was a problem hiding this comment.
see comment above re: wildcard/https
JFrankfurt
previously approved these changes
Jul 30, 2024
ricardoMogg
previously approved these changes
Jul 30, 2024
zencephalon
reviewed
Jul 30, 2024
apps/web/app/datadog.ts
Outdated
| import { datadogRum } from "@datadog/browser-rum"; | ||
|
|
||
| datadogRum.init({ | ||
| applicationId: process.env.DD_APP_ID || "", |
There was a problem hiding this comment.
Build is failing, wants ?? instead of || ditto below
cb-heimdall
dismissed stale reviews from JFrankfurt and ricardoMogg
Approved review 2208625175 from JFrankfurt is now dismissed due to new commit. Re-request for approval.
JFrankfurt
approved these changes
Jul 30, 2024
zencephalon
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Add datadog instrumentation for base-web
Notes to reviewers
How has it been tested?