Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in frontend docs #984

Merged
merged 5 commits into from
Sep 10, 2024
Merged

Fix typos in frontend docs #984

merged 5 commits into from
Sep 10, 2024

Conversation

gin
Copy link
Contributor

@gin gin commented Sep 7, 2024

What changed? Why?

  1. "were" should be "where"
  2. Markdown code block format ":::" should be "```"
  3. Code example's "use client": should be "use client";
  4. Consistent styling to RainbowKit and wagmi. Updated style to 'use client';
  5. Optimism's network information URL is broken. Updated link to https://docs.optimism.io/chain/networks

Notes to reviewers
n/a

How has it been tested?
Visually.

Copy link

vercel bot commented Sep 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2024 10:27pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 7, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Sep 7, 2024

@gin is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@gin gin changed the title Fix typo in wallet-connectors.md Fix typos in frontend docs Sep 8, 2024
@JFrankfurt JFrankfurt enabled auto-merge (squash) September 10, 2024 15:31
@JFrankfurt JFrankfurt merged commit 3af427d into base-org:master Sep 10, 2024
4 of 5 checks passed
@gin gin deleted the gin/fix-typo branch September 11, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants