Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and demo code in docs #995

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

gin
Copy link
Contributor

@gin gin commented Sep 12, 2024

What changed? Why?

useWriteContract docs:

  1. The tutorial useWriteContract() is using isPending instead of isLoading.
    Updated demo code to reflect this.

  2. you'll'll should be you'll

  3. Consistent codeblock MarkDown format where tsx: should be tsx

foundry setup docs:

  1. forge build: should be forge build

oracles docs:

  1. Chainlink's AggregatorV3Interface path is wrong. Updated path.
    https://docs.chain.link/data-feeds/using-data-feeds

Notes to reviewers
n/a

How has it been tested?
Visually.

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 1:45pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 1:45pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 12, 2024

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Copy link

vercel bot commented Sep 12, 2024

@gin is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@gin gin changed the title Fix typos and demo code in useWriteContract docs Fix typos and demo code in docs Sep 14, 2024
Copy link
Collaborator

@zencephalon zencephalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank U for making these changes!

@zencephalon zencephalon merged commit ba77227 into base-org:master Sep 20, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants