Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Server-side events for basenames claim frame #999

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feat: Server-side events for basenames claim frame #999

wants to merge 3 commits into from

Conversation

brendan-defi
Copy link
Collaborator

@brendan-defi brendan-defi commented Sep 13, 2024 •
edited
Loading

What changed? Why?

  • created utility for logging server-side events
  • implemented server-side event logging throughout basenames claim frame

Notes to reviewers

  • I have been unable to get the events to work for the development config. Currently hardcoding to prod config.

How has it been tested?
locally

@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 6:00pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 6:00pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 13, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@brendan-defi brendan-defi changed the title Feat: Utility for logging server-side events Feat: Server-side events for basenames claim frame Sep 13, 2024
@brendan-defi brendan-defi marked this pull request as ready for review September 13, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brendan-defi @cb-heimdall