Merge pull request #109 from mitchclarkebase2/fix

Add logic for resources with Id in a lower level
base2Services · Jun 20, 2023 · d7cd28b · d7cd28b
2 parents 3c23432 + 63de360
commit d7cd28b
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/lib/cfnguardian/compile.rb b/lib/cfnguardian/compile.rb
@@ -90,8 +90,18 @@ def get_resources
       @resource_groups.each do |group,resources|
         resources.each do |resource|
           if !resource.has_key?('Id')
-            @errors << "CfnGuardian::NoIdKeyForResourceError - resource: #{resource} in resource group: #{group} doesn't have the `Id:` key"
-            next
+            if !resource.has_key?('Hosts')
+              @errors << "CfnGuardian::NoIdKeyForResourceError - resource: #{resource} in resource group: #{group} doesn't have the `Id:` key"
+              next
+            else
+              resource['Hosts'].each { |host|
+                if !host.has_key?('Id')
+                  @errors << "CfnGuardian::NoIdKeyForResourceError - resource: #{resource} in resource group: #{group} doesn't have the `Id:` key"
+                  next
+                end
+              }
+
+            end
           end
 
           begin