fix phpstan errors caused by type hint changes

basvandorst · May 21, 2022 · 82ccfdf · 82ccfdf
1 parent e2addcd
commit 82ccfdf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Strava/API/Client.php b/src/Strava/API/Client.php
@@ -414,7 +414,7 @@ public function createActivity(string $name, string $type, string $start_date_lo
      * Upload an activity
      *
      * @link    https://strava.github.io/api/v3/uploads/#post-file
-     * @param $file
+     * @param string $file Path to file
      * @param string|null $activity_type
      * @param string|null $name
      * @param string|null $description
@@ -426,7 +426,7 @@ public function createActivity(string $name, string $type, string $start_date_lo
      * @return  array
      * @throws Exception
      */
-    public function uploadActivity($file, string $activity_type = null, string $name = null, string $description = null, int $private = null, int $trainer = null, int $commute = null, string $data_type = null, string $external_id = null): array
+    public function uploadActivity(string $file, string $activity_type = null, string $name = null, string $description = null, int $private = null, int $trainer = null, int $commute = null, string $data_type = null, string $external_id = null): array
     {
         try {
             return $this->service->uploadActivity($file, $activity_type, $name, $description, $private, $trainer, $commute, $data_type, $external_id);

diff --git a/src/Strava/API/Service/REST.php b/src/Strava/API/Service/REST.php
@@ -63,8 +63,8 @@ protected function getToken()
     protected function getResult($response)
     {
         // Workaround for export methods getRouteAsGPX, getRouteAsTCX:
-        // @phpstan-ignore-next-line
         if (is_string($response)) {
+            // @phpstan-ignore-next-line
             return $response;
         }