Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #5

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Release 2.0.0 #5

wants to merge 6 commits into from

Conversation

zw963
Copy link

@zw963 zw963 commented May 1, 2019

API changes:

  1. change macro names to macro-start, macro-stop, macro-save, more easy to remember.
  2. Remove highline dependency, don't ask macro name when run macro-stop, instead, need provide macro name when run macro-start
  3. macro-save save macro to ~/.pry-macro instead of ~/.pryrc, still will autoload all macros too.
  4. when recording macro, will skip edit command, this will permit you use your favorited editor to edit macro!

Bugfix:

  1. Fix for work with newest Pry.

@baweaver
Copy link
Owner

baweaver commented May 4, 2019

👀

Just got back from a conference, taking a look.

@@ -22,11 +24,10 @@ self.methods: inspect to_s
locals: _ __ _dir_ _ex_ _file_ _in_ _out_ _pry_
```

Stop the recording and name it:
Stop the recording:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/record/recording

lib/pry-macro.rb Outdated Show resolved Hide resolved
lib/pry-macro.rb Outdated Show resolved Hide resolved
@zw963
Copy link
Author

zw963 commented May 15, 2019

Do you consider add me as a container for this gem?

thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants