Update dependencies and api #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the option to define an API version, now it is hardcoded, setting it as v2
Removes everything regarding the fingerprint feature from the library code
Updates the existing API endpoints, and adds the endpoints for the blocklist and whitelist
Updates the name of the field feedbak_api_trans_code to bayonet_tracking_id in order to match with the current version of the API
Updates the request bodies used for the tests, this in order to match with the required structure in the current version of the API. Also updates how the API key is added to the request body.
Updates the existing tests to match with the changes made to use the version v2 of the API
Adds test for the blocklist and whitelists, only the blocklist endpoint is used, since the function of both lists is the same in terms of restrictions and limitations
Adds a line to close the Session object after being used for the request to the API, this to get rid of a warning when running tests in Python 3.x (ResourceWarning: unclosed <ssl.SSLSocket fd=6, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes include: