rules_jvm_external version 6 depends on rules_java
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lays the groundwork for pulling in the same version as `rules_jvm_external` when using a workspace-based build.
illicitonion
approved these changes
Jan 15, 2024
rdesgroppes
reviewed
Jan 17, 2024
Comment on lines
+57
to
+65
| elif major_version == "6": | ||
| maybe( | ||
| http_archive, | ||
| name = "rules_java", | ||
| urls = [ | ||
| "https://github.com/bazelbuild/rules_java/releases/download/6.5.2/rules_java-6.5.2.tar.gz", | ||
| ], | ||
| sha256 = "16bc94b1a3c64f2c36ceecddc9e09a643e80937076b97e934b96a8f715ed1eaa", | ||
| ) |
There was a problem hiding this comment.
Hum, doesn't work for me, with bazel 6.4.0:
ERROR: /path/to/external/remote_java_tools_linux/BUILD:27:23: @remote_java_tools_linux//:toolchain: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:32:23: @remote_java_tools_linux//:toolchain_hostjdk8: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:41:23: @remote_java_tools_linux//:legacy_toolchain: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:49:23: @remote_java_tools_linux//:legacy_toolchain_jvm8: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:56:23: @remote_java_tools_linux//:toolchain_vanilla: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:65:31: @remote_java_tools_linux//:toolchain_java8: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:72:31: @remote_java_tools_linux//:toolchain_java8_jvm8: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:65:31: @remote_java_tools_linux//:toolchain_java9: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:72:31: @remote_java_tools_linux//:toolchain_java9_jvm8: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:65:31: @remote_java_tools_linux//:toolchain_java10: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:72:31: @remote_java_tools_linux//:toolchain_java10_jvm8: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:65:31: @remote_java_tools_linux//:toolchain_java11: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:72:31: @remote_java_tools_linux//:toolchain_java11_jvm8: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:83:23: @remote_java_tools_linux//:toolchain_jdk_14: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:90:23: @remote_java_tools_linux//:toolchain_jdk_15: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/remote_java_tools_linux/BUILD:96:23: @remote_java_tools_linux//:prebuilt_toolchain: missing value for mandatory attribute 'java_runtime' in 'java_toolchain' rule
ERROR: /path/to/external/bazel_tools/tools/jdk/BUILD:171:14: Target '@remote_java_tools_linux//:prebuilt_singlejar' contains an error and its package is in error and referenced by '@bazel_tools//tools/jdk:prebuilt_singlejar_linux'
I seem to need rules_java 7.x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the groundwork for pulling in the same version as
rules_jvm_externalwhen using a workspace-based build.