Skip to content

Commit

Permalink
optional arg
Browse files Browse the repository at this point in the history
  • Loading branch information
keith committed Aug 21, 2023
1 parent 43a00f5 commit 2eefe06
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 0 additions & 2 deletions test/binary_tests.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ def binary_test_suite(name):
cpus = {"ios_multi_cpus": "x86_64"},
compilation_mode = "fastbuild",
objc_enable_binary_stripping = False,
expected_platform_type = "visionos",
verifier_script = "//test:verify_unused_symbol_exists.sh",
target_under_test = "//test/test_data:ios_app_with_unused_symbol",
tags = [name],
Expand All @@ -64,7 +63,6 @@ def binary_test_suite(name):
cpus = {"ios_multi_cpus": "x86_64"},
compilation_mode = "opt",
objc_enable_binary_stripping = True,
expected_platform_type = "visionos",
verifier_script = "//test:verify_stripped_symbols.sh",
target_under_test = "//test/test_data:ios_app_with_unused_symbol",
tags = [name],
Expand Down
1 change: 1 addition & 0 deletions test/rules/apple_verification_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ cpu's to use for test under target (e.g. {'ios_multi_cpus': ['arm64', 'x86_64']}
""",
),
"expected_platform_type": attr.string(
default = "",
doc = """
The apple_platform_type the binary should have been built for.
""",
Expand Down

0 comments on commit 2eefe06

Please sign in to comment.