Remove apple_common transitions #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed upstream but we still need the smallest possible transition for testing, this copies the one from rules_apple and removes a bunch of the features. If this ends up being too much of a pain to update we'll have to find a different solution.
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins,
thii and
mattrobmattrob
as code owners
This reverts commit 557daa2.
keith
commented
Aug 12, 2023
| }, | ||
| cfg = apple_common.apple_crosstool_transition, |
There was a problem hiding this comment.
not sure why but removing this seemed to be a no-op for our tests so i guess we don't have to worry about this one atm
keith
commented
Aug 12, 2023
|
|
||
| def _apple_platform_split_transition_impl(settings, attr): | ||
| output_dictionary = {} | ||
| if settings["//command_line_option:incompatible_enable_apple_toolchain_resolution"]: |
There was a problem hiding this comment.
we don't need this branch for now but i figure we might later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was removed upstream but we still need the smallest possible
transition for testing, this copies the one from rules_apple and removes
a bunch of the features. If this ends up being too much of a pain to
update we'll have to find a different solution.