Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build flags to allow overriding platforms used in transitions #263

Conversation

brentleyjones
Copy link
Collaborator

@brentleyjones brentleyjones commented Sep 20, 2023

This allows people to use custom versions of the platforms, including child platforms of the default ones, which allows for custom additional constraints and platform properties.

Signed-off-by: Brentley Jones <github@brentleyjones.com>
Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones
Copy link
Collaborator Author

I now think they should have a suffix of _default instead of a prefix. Then it reads more like "this is cpu ios_sim_arm's default platform".

And "default" is probably wrong, because the default value for them is the default, but you are mostly likely changing it away from the default if you use the flag.

So maybe it should actually be in a different package (root?) and named something like @apple_support//:ios_sim_arm_platform (which admittedly is a little confusing with the platforms package existing as well). This makes sense to me though because when set by a user they are expressing what is changing (--@apple_support//:ios_sim_arm_platform=//custom_platforms:ios_sim or their default value --@apple_support//:ios_sim_arm_platform=@apple_support//platforms:ios_sim_arm).

@keith
Copy link
Member

keith commented Sep 20, 2023

sounds fine, i also think it would be fine if they were still in the platforms package, but no strong pref

@brentleyjones
Copy link
Collaborator Author

--@apple_support//platforms:ios_sim_arm_platform=//custom_platforms:ios_sim, yeah, that's not too bad, will go with that.

Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones brentleyjones enabled auto-merge (squash) September 20, 2023 15:29
@brentleyjones brentleyjones merged commit b360aac into master Sep 20, 2023
9 of 11 checks passed
@brentleyjones brentleyjones deleted the bj/add-build-flags-to-allow-overriding-platforms-used-in-transitions branch September 20, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants