Only enable linkmap if the variable exists #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rules_apple we've started using cc_common.link in 1 place, which doesn't set this variable in bazel since this is an Apple specific feature in bazel. This means if you try to link a intents stub binary and pass `--objc_generate_linkmap` the link will fail. We don't care about generating linkmaps for that binary anyways since it's just an intermediate artifact, so this fixes that link. This has the downside that this could hide issues and silently not create linkmaps for links that should support them in the future.
|
Thanks! I verified this fixes the issue locally. |
keith
requested review from
BalestraPatrick,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
|
thanks! |
luispadron
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rules_apple we've started using cc_common.link in 1 place, which
doesn't set this variable in bazel since this is an Apple specific
feature in bazel. This means if you try to link a intents stub binary
and pass
--objc_generate_linkmapthe link will fail. We don't careabout generating linkmaps for that binary anyways since it's just an
intermediate artifact, so this fixes that link. This has the downside
that this could hide issues and silently not create linkmaps for links
that should support them in the future.