Migrate the first batch of Xcode rules' unit tests from Java to Starlark. #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ark. This moves tests from `XcodeVersionTest.java` and part of `XcodeConfigTest.java`. The latter is so large that I'm breaking it up into multiple changes to keep the individual ones smaller. It also stubs out the tests from `AvailableXcodesTest.java`, but the provider they use is restricted to built-in Starlark, so we can't actually migrate those yet. Since the rules in `apple_support` are still just forwarding to the native rules, these tests will be verifying their behavior. This is what we want, because when we migrate the rule implementations themselves over to `apple_support`, we can verify that we did it correctly via these tests. Unfortunately, some tests can't be migrated, because Starlark tests don't let you set `--experimental_*` flags in config transitions. If those flags are still needed, we may need to migrate them to Starlark as well. PiperOrigin-RevId: 627111681 (cherry picked from commit 99ffc6a) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
requested review from
BalestraPatrick,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
referenced
this pull request
Apr 22, 2024
…ark. This moves tests from `XcodeVersionTest.java` and part of `XcodeConfigTest.java`. The latter is so large that I'm breaking it up into multiple changes to keep the individual ones smaller. It also stubs out the tests from `AvailableXcodesTest.java`, but the provider they use is restricted to built-in Starlark, so we can't actually migrate those yet. Since the rules in `apple_support` are still just forwarding to the native rules, these tests will be verifying their behavior. This is what we want, because when we migrate the rule implementations themselves over to `apple_support`, we can verify that we did it correctly via these tests. Unfortunately, some tests can't be migrated, because Starlark tests don't let you set `--experimental_*` flags in config transitions. If those flags are still needed, we may need to migrate them to Starlark as well. PiperOrigin-RevId: 627111681
keith
approved these changes
Apr 23, 2024
brentleyjones
deleted the
bj/migrate-the-first-batch-of-xcode-rules-unit-tests-from-java-to-starlark
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves tests from
XcodeVersionTest.javaand part ofXcodeConfigTest.java. The latter is so large that I'm breaking it up into multiple changes to keep the individual ones smaller. It also stubs out the tests fromAvailableXcodesTest.java, but the provider they use is restricted to built-in Starlark, so we can't actually migrate those yet.Since the rules in
apple_supportare still just forwarding to the native rules, these tests will be verifying their behavior. This is what we want, because when we migrate the rule implementations themselves over toapple_support, we can verify that we did it correctly via these tests.Unfortunately, some tests can't be migrated, because Starlark tests don't let you set
--experimental_*flags in config transitions. If those flags are still needed, we may need to migrate them to Starlark as well.PiperOrigin-RevId: 627111681
(cherry picked from commit 99ffc6a)