Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork the Xcode rules from Bazel built-in Starlark into apple_support #332

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fork the Xcode rules from Bazel built-in Starlark into apple_support #332

wants to merge 1 commit into from
+766 −26

Conversation

brentleyjones
Copy link
Collaborator

PiperOrigin-RevId: 631018102
(cherry picked from commit f1bbadc)

brentleyjones referenced this pull request May 17, 2024
@allevato @swiple-rules-gardener
Fork the Xcode rules from Bazel built-in Starlark into apple_support.
f1bbadc 
PiperOrigin-RevId: 631018102
@brentleyjones
Copy link
Collaborator Author

These new rules only work with Bazel 8. We should:

  1. Add a feature to bazel_features so people can detect the apple_common.XcodeVersionConfig signature change and the addition of apple_fragment.xcode_version_flag
  2. Error early if someone tries to use these rules on an unsupported Bazel version

@brentleyjones brentleyjones changed the title Fork the Xcode rules from Bazel built-in Starlark into apple_support. Fork the Xcode rules from Bazel built-in Starlark into apple_support May 17, 2024
Base automatically changed from bj/migrate-the-rest-of-the-xcode-tests-from-bazel-core-java-to-starlark-except-those-that-can-t-be-migrated-because-they-use-experimental-flags to master May 31, 2024 11:26
@allevato @brentleyjones
Fork the Xcode rules from Bazel built-in Starlark into apple_support.
0642071 
PiperOrigin-RevId: 631018102
(cherry picked from commit f1bbadc)
@brentleyjones brentleyjones force-pushed the bj/fork-the-xcode-rules-from-bazel-built-in-starlark-into-apple_support branch from 4d43dbc to 0642071 Compare May 31, 2024 12:33
@brentleyjones brentleyjones marked this pull request as ready for review May 31, 2024 12:33
@brentleyjones brentleyjones mentioned this pull request Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thii thii thii approved these changes

@mattrobmattrob mattrobmattrob mattrobmattrob approved these changes

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brentleyjones @thii @mattrobmattrob @allevato