Fix oso_prefix paths #347
Merged
Fix oso_prefix paths #347
+70
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bazel executions actions in the sandbox, pwd is a path like this: ``` /private/var/tmp/_bazel_ksmiley/92410d0e3373f265902564b48493ac12/sandbox/darwin-sandbox/8/execroot/_main ``` Inside this directory are the inputs, which are symlinks to outside of this pwd: ``` /private/var/tmp/_bazel_ksmiley/92410d0e3373f265902564b48493ac12/sandbox/darwin-sandbox/1/execroot/_main/bazel-out/darwin_arm64-dbg/bin/_objs/main/main.o -> /private/var/tmp/_bazel_ksmiley/92410d0e3373f265902564b48493ac12/execroot/_main/bazel-out/darwin_arm64-dbg/bin/_objs/main/main.o ``` ld64 resolves the absolute path to this object file, including resolving symlinks, _before_ it strips the -oso_prefix argument. Because of this the previous `__BAZEL_EXECUTION_ROOT__` replacement, which was the sandbox pwd, isn't actually a prefix of the canonicalized object file path, leading to -oso_prefix being a no-op, and absolute paths ending up in the binary. I think many folks didn't see this locally because it's common for Apple projects to disable sandboxing for local development for perf reasons, and that's when you're likely to have this debug info in the binary in the first place. With this change we add a new substitution that calculates the sandbox-independent prefix and passes that along instead.
keith
requested review from
BalestraPatrick,
brentleyjones,
luispadron,
mattrobmattrob and
thii
as code owners
brentleyjones
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bazel executions actions in the sandbox, pwd is a path like this:
Inside this directory are the inputs, which are symlinks to outside of
this pwd:
ld64 resolves the absolute path to this object file, including resolving
symlinks, before it strips the -oso_prefix argument. Because of this
the previous
__BAZEL_EXECUTION_ROOT__replacement, which was thesandbox pwd, isn't actually a prefix of the canonicalized object file
path, leading to -oso_prefix being a no-op, and absolute paths ending up
in the binary.
I think many folks didn't see this locally because it's common for Apple
projects to disable sandboxing for local development for perf reasons,
and that's when you're likely to have this debug info in the binary in
the first place.
With this change we add a new substitution that calculates the
sandbox-independent prefix and passes that along instead.