Skip to content

Commit

Permalink
Disable lockfile check for BCR test module (#1673)
Browse files Browse the repository at this point in the history
Enforcing an up-to-date lockfile made contributions more complicated.
  • Loading branch information
fmeum committed Dec 2, 2023
1 parent b625896 commit d76c08f
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 2,854 deletions.
13 changes: 0 additions & 13 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,6 @@ tasks:
- rm pkg/BUILD.bazel
- bazel run //:gazelle -- update pkg
- bazel run //:gazelle -- pkg
build_flags:
# Verify that the committed lockfile is platform-independent.
# In case of expected changes, regenerate the lockfile with
# `bazel mod graph`, which evaluates all module extensions.
# Note: `go_sdk`s *is* platform-dependent since it registers the first
# host-compatible SDK, but the result only differs if there is also a
# matching SDK with manual goos/goarch set, which isn't the case in CI.
# TODO: Make this more realistic after
# https://github.com/bazelbuild/bazel/issues/19154.
- "--lockfile_mode=error"
test_flags:
# See above.
- "--lockfile_mode=error"
build_targets:
- "//..."
- "//:gazelle"
Expand Down
3 changes: 0 additions & 3 deletions .gitattributes

This file was deleted.

1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@
/tests/bcr/bazel-bin
/tests/bcr/bazel-out
/tests/bcr/bazel-testlogs
/tests/bcr/MODULE.bazel.lock
.DS_STORE
.ijwb/
Loading

0 comments on commit d76c08f

Please sign in to comment.