Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specify nojdk and non-release commit #469

Closed
c-parsons opened this issue May 24, 2023 · 2 comments
Closed

Allow specify nojdk and non-release commit #469

c-parsons opened this issue May 24, 2023 · 2 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) type: feature request New feature or request

Comments

@c-parsons
Copy link

It looks like one cannot specify a non-release commit (e.g. USE_BAZEL_VERSION=last_green) as well as BAZEL_NOJDK=1 to download a nojdk Bazel.

Instead, it will download a jdk Bazel (BAZEL_NOJDK is ignored).

This seems like a simple arg-parsing oversight. (FWIW, BAZEL_NOJDK isn't even documented, so perhaps its a mostly-untested feature?)

@tradergt
Copy link

For the java part, looks like there was a push to support NOJDK
#531
It has not been released yet though

@fweikert
Copy link
Member

fweikert commented Feb 6, 2024

I'll cut a new release

@fweikert fweikert closed this as completed Feb 6, 2024
@fweikert fweikert added the type: feature request New feature or request label Feb 6, 2024
@fweikert fweikert self-assigned this Feb 6, 2024
@fweikert fweikert added the P1 I'll work on this now. (Assignee required) label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants