Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for BAZELISK_NOJDK to Go Bazelisk #531

Merged
merged 4 commits into from
Jan 23, 2024

Conversation

sf-jbazuzi
Copy link
Contributor

@sf-jbazuzi sf-jbazuzi commented Jan 18, 2024

Inspired by #315 but implemented from scratch.

Fixes #430.

See individual commits in the PR for easier review.

@fweikert fweikert self-requested a review January 23, 2024 16:55
@fweikert fweikert added the P1 I'll work on this now. (Assignee required) label Jan 23, 2024
@fweikert fweikert merged commit 0c6620a into bazelbuild:master Jan 23, 2024
2 checks passed
ti-chi-bot bot referenced this pull request in PingCAP-QE/artifacts Jul 3, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [bazelbuild/bazelisk](https://github.com/bazelbuild/bazelisk) |
minor | `v1.19.0` -> `v1.20.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/bazelisk (bazelbuild/bazelisk)</summary>

###
[`v1.20.0`](https://github.com/bazelbuild/bazelisk/releases/tag/v1.20.0)

[Compare
Source](https://github.com/bazelbuild/bazelisk/compare/v1.19.0...v1.20.0)

Bazelisk v1.20.0 comes with several significant changes:

### New Features

- The Go version now supports `BAZELISK_NOJDK`
([https://github.com/bazelbuild/bazelisk/pull/531](https://github.com/bazelbuild/bazelisk/pull/531))

### Bug Fixes & Improvements

- It's now easier to use Bazelisk programmatically
([https://github.com/bazelbuild/bazelisk/pull/500](https://github.com/bazelbuild/bazelisk/pull/500),
[https://github.com/bazelbuild/bazelisk/pull/526](https://github.com/bazelbuild/bazelisk/pull/526))
- Bazelisk will retry more connection errors
([https://github.com/bazelbuild/bazelisk/pull/529](https://github.com/bazelbuild/bazelisk/pull/529),
[https://github.com/bazelbuild/bazelisk/pull/530](https://github.com/bazelbuild/bazelisk/pull/530))
- A display bug in the download progress bar has been fixed
([https://github.com/bazelbuild/bazelisk/pull/539](https://github.com/bazelbuild/bazelisk/pull/539))

We’d like to thank our amazing contributors
[@&#8203;afq984](https://github.com/afq984),
[@&#8203;comius](https://github.com/comius),
[@&#8203;francine-blanc](https://github.com/francine-blanc),
[@&#8203;illicitonion](https://github.com/illicitonion),
[@&#8203;jwnimmer-tri](https://github.com/jwnimmer-tri),
[@&#8203;LINKIWI](https://github.com/LINKIWI),
[@&#8203;mmorel-35](https://github.com/mmorel-35) and
[@&#8203;sf-jbazuzi](https://github.com/sf-jbazuzi)!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/PingCAP-QE/artifacts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjMuNSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJoZWxwIHdhbnRlZCJdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to use custom JDK
2 participants