Add --//some/path:incompatible_some_flag as a valid incompatible flag format #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a unit test for the migration issue scanner. This PR adds no new behavior. It just refactors getIncompatibleFlags so we can add a test for new behavior to be added for bazelbuild#118
for incompatible flags Closes bazelbuild#118
|
Does that mean we have actual flags that start with Like this? |
|
On Tue, Mar 10, 2020 at 8:56 AM Philipp Wollermann ***@***.***> wrote:
Does that mean we have actual flags that start with -- and then go on
with a label syntax in Bazel?
Like this?
bazel build --//some/path:incompatible_user_defined_flag --spawn_strategy=foobar //my:app
Yes. bazelbuild/bazel#8857
It is removal of starlark build_defs. As we get incompatible changes in
rules we are going to see more of this.
… —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#125?email_source=notifications&email_token=AAXHHHCLEKFKHXH4CQIBSMTRGY2IFA5CNFSM4LEWW4L2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOLJHOA#issuecomment-597070776>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHEUNNYZP5EG2WAU2NTRGY2IFANCNFSM4LEWW4LQ>
.
|
|
friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #118