fix: don't pass auth token in getFilteredVersions with BAZELISK_GITHUB_TOKEN is unset #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @alexeagle |
|
cc @fweikert |
gregmagolan
added a commit
to aspect-build/aspect-cli
that referenced
this pull request
Jan 18, 2023
Arguments to HasPrefix were backwards when checking if a bazelisk bootstrap is configured. Also check for `aspect-cli/` prefix to future-proof for after bazelbuild/bazelisk#412 lands and check for `aspect-build/` as alternative to `aspect.build/` in baseURL. I will add adding integrations tests to the CLI loose ends list for Q1. GitOrigin-RevId: 0da2a78c4e9afb917a2f47112f96fe0c3468a8bd
gregmagolan
added a commit
to aspect-build/aspect-cli
that referenced
this pull request
Jan 19, 2023
Arguments to HasPrefix were backwards when checking if a bazelisk bootstrap is configured. Also check for `aspect-cli/` prefix to future-proof for after bazelbuild/bazelisk#412 lands and check for `aspect-build/` as alternative to `aspect.build/` in baseURL. I will add adding integrations tests to the CLI loose ends list for Q1. GitOrigin-RevId: 0da2a78c4e9afb917a2f47112f96fe0c3468a8bd
fweikert
approved these changes
Feb 1, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested this locally with a
.bazeliskrcfile with the following contents:This will get the latest release from https://github.com/aspect-cli/bazel/releases.