Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for tools/bazel.ps1 and tools/bazel.bat on Windows #417

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

UebelAndre
Copy link
Contributor

closes #416

@google-cla
Copy link

google-cla bot commented Jan 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@UebelAndre UebelAndre force-pushed the windows branch 4 times, most recently from 7275167 to b6b3acc Compare January 24, 2023 05:59
@UebelAndre
Copy link
Contributor Author

@philwo @fweikert hey, would either of you be able to take a look at this PR? 😅

@fweikert
Copy link
Member

fweikert commented Jan 30, 2023

Nice, thanks for this PR (and especially for adding a test!). I'll reserve some time tomorrow to work this PR and the others in our backlog.

Edit: Will have to postpone to Wednesday given the Bazel CI infra update and the resulting outage.

core/core.go Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
Copy link
Member

@fweikert fweikert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, especially for adding the test!

@UebelAndre
Copy link
Contributor Author

Thank you so much, especially for adding the test!

Thanks for the review! Would it be possible to get a new release with this change in it? 🙏

@fweikert
Copy link
Member

fweikert commented Feb 1, 2023

Yeah, I'll try to merge some more PRs, then I'll cut a new release tomorrow (Thursday).

@UebelAndre
Copy link
Contributor Author

Yeah, I'll try to merge some more PRs, then I'll cut a new release tomorrow (Thursday).

Thanks! I was gonna make an issue to track the release but seems #411 already exists. I'll subscribe to that and I'm eagerly looking forward to the new version 😄

@fweikert fweikert merged commit efa473d into bazelbuild:master Feb 2, 2023
@UebelAndre UebelAndre deleted the windows branch February 2, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Support tools/bazel with extensions on Windows
2 participants