-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tools/bazel.ps1
and tools/bazel.bat
on Windows
#417
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
7275167
to
b6b3acc
Compare
Nice, thanks for this PR (and especially for adding a test!). I'll reserve some time tomorrow to work this PR and the others in our backlog. Edit: Will have to postpone to Wednesday given the Bazel CI infra update and the resulting outage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, especially for adding the test!
Thanks for the review! Would it be possible to get a new release with this change in it? 🙏 |
Yeah, I'll try to merge some more PRs, then I'll cut a new release tomorrow (Thursday). |
Thanks! I was gonna make an issue to track the release but seems #411 already exists. I'll subscribe to that and I'm eagerly looking forward to the new version 😄 |
closes #416