Add progress display during binary downloads. #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand the test failures: this appears to be fine in Buildkite on the master branch, but when I run the same test at master locally it fails with the same 404 error. |
|
See also #5 for the python counterpart |
katre
force-pushed
the
download-progress
branch
from
0729314
to
2fc96b6
Compare
meteorcloudy
approved these changes
Nov 13, 2023
ti-chi-bot bot
referenced
this pull request
in PingCAP-QE/artifacts
Nov 30, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [bazelbuild/bazelisk](https://github.com/bazelbuild/bazelisk) | minor | `v1.18.0` -> `v1.19.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/bazelisk (bazelbuild/bazelisk)</summary> ### [`v1.19.0`](https://github.com/bazelbuild/bazelisk/releases/tag/v1.19.0) [Compare Source](https://github.com/bazelbuild/bazelisk/compare/v1.18.0...v1.19.0) Bazelisk v1.19.0 comes with two significant changes: - `MODULE.bazel` and `REPO.bazel` files are now obeyed ([https://github.com/bazelbuild/bazelisk/pull/503](https://github.com/bazelbuild/bazelisk/pull/503)) - Users will see a progress bar during binary downloads ([https://github.com/bazelbuild/bazelisk/pull/511](https://github.com/bazelbuild/bazelisk/pull/511)) We’d like to thank our amazing contributors [@​crncnnr](https://github.com/crncnnr) and [@​katre](https://github.com/katre)! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/PingCAP-QE/artifacts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
754715
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of progress message:
When using stdout this will be overwritten repeatedly.