Dont assume docker path in image util

[massemanet]

"image_util.sh" does not respect the docker toolchain.
this PR generates "image_util.sh" from a template instead.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[massemanet]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[smukherj1]

/gcbrun

[smukherj1]

Thanks!

[smukherj1]

Oops. Didn't notice there are CI errors. Could you please fix the following?

(12:07:37) ERROR: /workdir/docker/util/run.bzl:176:18: name 'image_utils' is not defined
--
  | (12:07:37) DEBUG: /workdir/cc/image.bzl:79:9: cc_image does not benefit from layers=[], got: [":cc_image_library"]
  | (12:07:37) ERROR: error loading package 'tests/docker/util': Extension 'docker/util/run.bzl' has errors
  | (12:07:37) ERROR: error loading package 'tests/contrib': in /workdir/docker/toolchain_container/toolchain_container.bzl: in /workdir/docker/toolchain_container/debian_pkg_tar.bzl: in /workdir/docker/package_managers/apt_key.bzl: Extension 'docker/util/run.bzl' has errors
  | (12:07:37) ERROR: error loading package 'tests/docker/package_managers': in /workdir/docker/package_managers/apt_key.bzl: Extension 'docker/util/run.bzl' has errors
  | (12:07:37) ERROR: error loading package 'tests/docker/toolchain_container': in /workdir/docker/toolchain_container/toolchain_container.bzl: in /workdir/docker/toolchain_container/debian_pkg_tar.bzl: in /workdir/docker/package_managers/apt_key.bzl: Extension 'docker/util/run.bzl' has errors
  | (12:07:37) ERROR: Skipping '//tests/contrib:derivative_with_volume_repro_test': error loading package 'tests/contrib': in /workdir/docker/toolchain_container/toolchain_container.bzl: in /workdir/docker/toolchain_container/debian_pkg_tar.bzl: in /workdir/docker/package_managers/apt_key.bzl: Extension 'docker/util/run.bzl' has errors

[massemanet]

tests seemingly passes
/assign @smukherj1

[nlopezgi]

buildkite is still failing with error message:

(10:16:56) ERROR: /workdir/tests/docker/util/BUILD:69:1: in container_run_and_commit rule //tests/docker/util:test_container_commit:
Traceback (most recent call last):
	File "/workdir/tests/docker/util/BUILD", line 69
		container_run_and_commit(name = 'test_container_commit')
	File "/workdir/docker/util/run.bzl", line 185, in _commit_impl
		ctx.actions.expand_template(<4 more arguments>)
	File "/workdir/docker/util/run.bzl", line 200, in ctx.actions.expand_template
		ctx.file.image_utils
No attribute 'image_utils' in file. Make sure there is a label type attribute marked as 'allow_single_file' with this name
Available attributes: _image_utils_tpl, _run_tpl, image

line 200 in run.bzl should probably be
"%{util_script}": image_utils.path,
instead of
"%{util_script}": ctx.file.image_utils.path,

This is a syntax error and you should be able to repro these locally and debug them yourself. Please make sure you can build and test this locally (and that the buildkite tests pass) before pinging again (unless you get stuck and need a hand debugging) as otherwise we will be doing too much back and forth.

[nlopezgi]

/gcbrun

[massemanet]

tests seemingly passes
/assign @smukherj1

[massemanet]

argh. apologies for messing up your workflow here

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: massemanet, nlopezgi, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nlopezgi,smukherj1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Outdated