added support for user defined tags on generated container_import r…

[sha1n]

@nlopezgi this is my proposed fix for #764
I tested this with --experimental_allow_tags_propagation and it works as expected. Without the flag, the GUNZIP and GZIP actions will run against remote-cache. But this is expected and this PR solves a more generic case and is not specific to remote-caching.

A few notes:

• I'm not so sure about the name of the attribute on the container_pull repo rule.. will be happy to hear other suggestions.
• I am unable to build/test this repository on my MacOS environment, is there any special setup I need to do?
• What about testing? Can you give me some pointers to something I can follow in order to test this?

[nlopezgi]

There's not really any way that I can think of to test this, other than manually verifying the produced BUILD file does have the right tags, and checking the expected behavior. So can you just verify this is working as intended for you and then we can merge, change is simple enough

[sha1n]

So can you just verify this is working as intended for you and then we can merge

@nlopezgi I tested this locally with the no-remote-cache tag + --experimental_allow_tags_propagation - works as intended.

[nlopezgi]

Can you please run buildifier on container/pull.bzl and update your branch? Should be good to go once the buildkite presubmit passes; I can then run gcbtests and approve and merge if everything passes.

[sha1n]

Thanks @nlopezgi. Done!

The build seems to fail on an unrelated issue. I think the cause is:

(06:21:20) ERROR: An error occurred during the fetch of repository 'zlib':
   java.io.IOException: Error downloading [https://zlib.net/zlib-1.2.11.tar.gz] to /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/zlib/zlib-1.2.11.tar.gz: connect timed out
(06:21:20) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/com_google_protobuf/BUILD:150:1: @com_google_protobuf//:protobuf depends on @zlib//:zlib in repository @zlib which failed to fetch. no such package '@zlib//': java.io.IOException: Error downloading [https://zlib.net/zlib-1.2.11.tar.gz] to /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/zlib/zlib-1.2.11.tar.gz: connect timed out

[nlopezgi]

Thanks @nlopezgi. Done!

The build seems to fail on an unrelated issue. I think the cause is:

(06:21:20) ERROR: An error occurred during the fetch of repository 'zlib':
   java.io.IOException: Error downloading [https://zlib.net/zlib-1.2.11.tar.gz] to /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/zlib/zlib-1.2.11.tar.gz: connect timed out
(06:21:20) ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/com_google_protobuf/BUILD:150:1: @com_google_protobuf//:protobuf depends on @zlib//:zlib in repository @zlib which failed to fetch. no such package '@zlib//': java.io.IOException: Error downloading [https://zlib.net/zlib-1.2.11.tar.gz] to /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/external/zlib/zlib-1.2.11.tar.gz: connect timed out

Yeah there's, an infra issue with our CI atm, I'll re run once that is resolved.

[nlopezgi]

/gcbrun

[nlopezgi]

Updating branch to see if Buildkite issue is now resolved

[nlopezgi]

/gcbrun

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, sha1n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nlopezgi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment