Move tests that use 'docker' to GCB #1290
Conversation
|
/gcbrun |
|
|
||
| steps: | ||
| - name: "l.gcr.io/google/bazel" | ||
| args: |
There was a problem hiding this comment.
Can we setup these tests to execute on RBE and not need a N1_HIGHCPU_32 machine?
tests/container/cloudbuild.yaml
Outdated
| - "//tests/container:new_alpine_linux_ppc64le_image_tar_test" | ||
| - "//tests/container:new_alpine_linux_ppc64le_image_oci_tar_test" | ||
| - "//tests/container:new_alpine_linux_ppc64le_image_oci_test" | ||
| - name: "l.gcr.io/google/bazel" |
There was a problem hiding this comment.
are these steps running in parallel? probably can be run in a single step and run on RBE and provide better performance.
There was a problem hiding this comment.
Done, runs on RBE now in a single step.
No, they weren't running in parallel, but I thought it would be easier to see where failures are coming from when the different tests are spread across different steps.
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| steps: |
There was a problem hiding this comment.
add doc explaining what these file is testing (i.e., tests that need docker in contrib directory)
There was a problem hiding this comment.
also, can we execute as well on RBE?
There was a problem hiding this comment.
Done
Except for moving tests under //tests/contrib/automatic_container_release to run on RBE. This is because RBE bots don't have the necessary permissions to pull the checker images.
| options: | ||
| machineType: "N1_HIGHCPU_32" | ||
|
|
||
| steps: |
There was a problem hiding this comment.
same as for the above, can we run on RBE, add docs, not use N1_HIGHCPU_32.
|
/gcbrun |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alex1545, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.