This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Run all BUILD/skylark files through buildifier #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, I'd love a buildifier presubmit check. :-/ |
sudarshang
pushed a commit
to sudarshang/rules_docker
that referenced
this pull request
Sep 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on adding some functionality to the rules, and my vim auto-runs buildifier, which was causing a bunch of unrelated diffs.
This change is the effect of running
github.com/bazelbuild/buildifieron allBUILDandbzlfiles in the repo. It should otherwise be a no-op.(It'd be nice to enable buildifier in travis or something, but I'm not sure how to get it installed there.)