This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Add stamp option to docker_bundle rule #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows using workspace status information (such as git describe) in image tags.
mattmoor
reviewed
May 1, 2017
docker/join_layers.py
Outdated
| with open(infofile) as info: | ||
| for line in info: | ||
| line = line.strip("\n") | ||
| key, value = line.split(" ") |
There was a problem hiding this comment.
you probably want line.split(" ", 1) (or maybe 2, I can never remember the sense of this)
docker/join_layers.py
Outdated
| for line in info: | ||
| line = line.strip("\n") | ||
| key, value = line.split(" ") | ||
| stamp_info[key] = value |
There was a problem hiding this comment.
Can you print a warning when key exists in the map?
ixdy
force-pushed
the
docker-bundle-stamping
branch
3 times, most recently
from
f159d08
to
8f590ca
Compare
ixdy
force-pushed
the
docker-bundle-stamping
branch
from
8f590ca
to
728572f
Compare
|
Thanks for the quick review! I've addressed your comments in a follow-up commit and can squash if desired. |
|
GitHub will let me squash and merge, but I'm happy to leave the history there. thanks for the change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using workspace status information (such as git describe) in image tags. To differentiate from make variables (and laziness), I'm using python formatting syntax, e.g.
{STABLE_BUILD_USER}or{MY_CUSTOM_VAR}.This is basically an implementation of what I was describing in #3 (comment).
I think it'd work for what I need for kubernetes right now, though I'm not sure if this is the correct implementation, e.g. does it makes sense to do the stamping in
docker_bundle? Should it also be supported indocker_buildand/ordocker_push? What things should be "stampable"? Do we want to be able to embed stamping info in image labels? (I might in the future, e.g. embed revision/other build data.)(
docker_pushactually looks harder, since it's basically just a shell script template wrapper to the code in containerregistry.)The proper way to do all of this would be entirely in skylark, though that depends on bazelbuild/bazel#1054 being resolved.