This repository has been archived by the owner on Oct 2, 2023. It is now read-only.
Add support for stamping docker_push #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damienmg
approved these changes
Jun 22, 2017
ixdy
reviewed
Jun 23, 2017
| name = "push_stamp", | ||
| image = ":link_with_files_base", | ||
| registry = "gcr.io", | ||
| repository = "convoy-adapter/bazel-test", |
There was a problem hiding this comment.
@samuraisam's note from #54: it might be worth putting a stamped value in here too. (it seems to work, but it'd be good to test.)
sudarshang
pushed a commit
to sudarshang/rules_docker
that referenced
this pull request
Sep 26, 2019
custom_outputs/ and default_outputs/ are replaced by predeclared_outputs/. executable/ is rewritten. Both of the new examples are gimmicky, but less trivial, so hopefully they provide some informative context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3
Fixes: #54